Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced jQuery .size() method with .length in form behavior #3655

Closed
wants to merge 5 commits into from
Closed

Replaced jQuery .size() method with .length in form behavior #3655

wants to merge 5 commits into from

Conversation

SimonArdrey
Copy link

.size() was depreciated in jQuery 1.8
This must have been missed back when the bug #1586 was fixed in 1.7

jlukic and others added 5 commits January 7, 2016 23:42
.size() was depreciated in jQuery 1.8
This must have been missed back when the bug #1586 was fixed in 1.7
@SimonArdrey SimonArdrey closed this Feb 5, 2016
@SimonArdrey SimonArdrey reopened this Feb 5, 2016
@SimonArdrey
Copy link
Author

Sorry I think I buggered up the PR. The commit I was trying to get through to the next branch is 'Replaced jQuery .size() method with .length' (a7b51b0)

@larsbo
Copy link
Contributor

larsbo commented Feb 8, 2016

I had the same PR problems. 😃
It happens when you create a branch from master and try to merge into next. If you are not very experienced with pull requests the contributing guide is a bit short...

@jlukic jlukic added this to the 2.1.9 milestone Feb 15, 2016
jlukic added a commit that referenced this pull request Feb 15, 2016
jlukic added a commit that referenced this pull request Feb 15, 2016
@jlukic jlukic closed this Feb 15, 2016
@jlukic
Copy link
Member

jlukic commented Feb 15, 2016

Added

@jlukic jlukic modified the milestones: 2.1.9, 2.2 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants