Skip to content

[🚀 Feature]: Enhancing PrintOptions to Utilize Predefined Defaults (e.g. A4, Tabloid, Legal, etc.) and Custom Sizes #15072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 5 tasks
shbenzer opened this issue Jan 13, 2025 · 5 comments
Assignees
Labels
A-needs decision TLC needs to discuss and agree A-needs-triaging A Selenium member will evaluate this soon! I-enhancement Something could be better

Comments

@shbenzer
Copy link
Contributor

shbenzer commented Jan 13, 2025

Feature and motivation

Per @nvborisenko's suggestion, this feature proposal will be used to organize/track efforts to implement the setting of predefined defaults (e.g. A4 or Tabloid.) and custom sizes across all bindings for the PrintOptions class.

Thank you @yvsvarma for getting these PRs rolling.

Usage example

Python:

print_options.set_page_size(PrintOptions.LEGAL)
@shbenzer shbenzer added I-enhancement Something could be better A-needs-triaging A Selenium member will evaluate this soon! labels Jan 13, 2025
Copy link

@shbenzer, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@nvborisenko
Copy link
Member

I interpret it as introducing some well-known/magic numbers to help people to use most-popular page sizes. From my point of view we should understand what is:

  • most popular
  • theirs magic numbers (spec ref)

I vote for implementing it, it is easy and helpful for end users with minimal supporting effort from our side.

@nvborisenko
Copy link
Member

https://papersizes.io/ and given that "Selenium automates browsers. That's it!" I am not sure we should do it.

@nvborisenko nvborisenko added the A-needs decision TLC needs to discuss and agree label Jan 18, 2025
@yvsvarma
Copy link
Contributor

Update: Ruby PR got merged too.

@yvsvarma
Copy link
Contributor

yvsvarma commented Apr 10, 2025

Update: Ruby PR got merged too.

@shbenzer , can you please update the description marking Ruby PR also approved/completed.
And, please assign this feature to me. Will work on JavaScript too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-needs decision TLC needs to discuss and agree A-needs-triaging A Selenium member will evaluate this soon! I-enhancement Something could be better
Projects
None yet
Development

No branches or pull requests

3 participants