Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add pressure thrust #769

Open
2 of 4 tasks
caioessouza opened this issue Feb 11, 2025 · 3 comments · May be fixed by #789
Open
2 of 4 tasks

ENH: Add pressure thrust #769

caioessouza opened this issue Feb 11, 2025 · 3 comments · May be fixed by #789

Comments

@caioessouza
Copy link
Contributor

caioessouza commented Feb 11, 2025

Is your feature request related to a problem? Please describe.

Rocketpy curetly does not take into account the thrust dependece on the ambient pressure: $(p_e-p_a)A_e$.

It's a important behaviour considering two situations: correction for thrust curves obtained from a static hot fire test performed in a altitude much different from the launch or in-flight corrections for high target altitude flights.

Describe the solution you'd like

Implement a optional method for take that behaviour into acount without crashing the current library behaviour.

Additional context

Image

To do list

  • Review theory
  • Check which parameter to add to the init of all motor classes
  • Implemet a function to split the input thrust curve in mass flow thrust and pressure thrust
  • Impelement the thrust correction in the flight simulation
@caioessouza
Copy link
Contributor Author

Based on #148

@kevin-alcaniz
Copy link
Contributor

At Faraday, we've made some changes to account for pressure thrust and correct the thrust force as the rocket ascends. Would you like me to open a PR?

@kevin-alcaniz kevin-alcaniz linked a pull request Mar 19, 2025 that will close this issue
8 tasks
@caioessouza
Copy link
Contributor Author

At Faraday, we've made some changes to account for pressure thrust and correct the thrust force as the rocket ascends. Would you like me to open a PR?

Sure, I just saw what you made at the issue #789 and it seems very good. Feel free to open the PR, thank you for the contribuition!

@Gui-FernandesBR Gui-FernandesBR linked a pull request Mar 25, 2025 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants