Skip to content

Commit fb47ddd

Browse files
authored
Merge pull request #82 from jschneider/error-handler
do not ignore exceptions, call RxJavaPlugins.onError instead
2 parents 2224bbd + 8257537 commit fb47ddd

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Diff for: src/main/java/io/reactivex/rxjavafx/observers/JavaFxObserver.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,16 @@
1515
*/
1616
package io.reactivex.rxjavafx.observers;
1717

18+
import java.util.Optional;
19+
1820
import io.reactivex.Observable;
1921
import io.reactivex.functions.Consumer;
2022
import io.reactivex.observables.ConnectableObservable;
23+
import io.reactivex.plugins.RxJavaPlugins;
2124
import io.reactivex.rxjavafx.observables.JavaFxObservable;
2225
import javafx.beans.binding.Binding;
2326
import javafx.beans.value.ObservableValue;
2427

25-
import java.util.Optional;
26-
2728
public enum JavaFxObserver {
2829
;//no instances
2930

@@ -141,6 +142,6 @@ public static <T> Binding<T> toLazyNullableBinding(Observable<Optional<T>> obs,
141142
}
142143

143144
private static void onError(Throwable t) {
144-
// nothing
145+
RxJavaPlugins.onError(t);
145146
}
146147
}

Diff for: src/main/java/io/reactivex/rxjavafx/observers/JavaFxSubscriber.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import io.reactivex.Flowable;
1919
import io.reactivex.flowables.ConnectableFlowable;
2020
import io.reactivex.functions.Consumer;
21+
import io.reactivex.plugins.RxJavaPlugins;
2122
import io.reactivex.rxjavafx.observables.JavaFxObservable;
2223
import javafx.beans.binding.Binding;
2324
import javafx.beans.value.ObservableValue;
@@ -141,6 +142,6 @@ public static <T> Binding<T> toLazyNullableBinding(Flowable<Optional<T>> flowabl
141142
}
142143

143144
private static void onError(Throwable t) {
144-
// nothing
145+
RxJavaPlugins.onError(t);
145146
}
146147
}

0 commit comments

Comments
 (0)