Replace BinaryFormatter with PSSerializer

[andyleejordan]

Description

Since the former has been removed from PowerShell 7.4 (because it was removed from .NET 7) and the latter can accomplish the same thing.

Issues Fixed

• Fixes Reliance on BinaryFormatter breaks module with PowerShell 7.4.0-preview.4 #413

References

N/A

Checklist

• You actually ran the code that you just wrote, especially if you did just "one last quick change".
• Comment-based help added/updated, including examples.
• Static analysis is reporting back clean.
• New/changed code adheres to our coding guidelines.
• Formatters were created for any new types being added.
• New/changed code continues to support the pipeline.
• Changes to the manifest file follow the manifest guidance.
• Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
• Relevant usage examples have been added/updated in USAGE.md.
• If desired, ensure your name is added to our Contributors list

[andyleejordan]

Ah we need to figure out what depth is sufficient:

The input object to serialize. Serializes to a default depth of 1.

...I set it to 64.

[andyleejordan]

@HowardWolosky the third commit is a little risker and you may want further testing of it. I verified my previous workflow still worked (and was previously erroring because of the use of BinaryFormatter). @SeeminglyScience pointed out to me that the whole function DeepCopy-Object was unnecessary and could be replaced with a simple addition in the loop to add the converted properties to the new clone object. It's an option, and I've left it in a separate commit if you want it (or you can just take the first two).

[HowardWolosky]

Thanks so much for bringing this to my attention with the issue, as well as for providing the fix!

Your change looks good (aside from the minor requested capitalization change) from a code perspective. I just need to run it through some tests to verify that there aren't any unexpected regressions that I'm missing from a cursory review.

[andyleejordan]

Thanks so much for bringing this to my attention with the issue, as well as for providing the fix!

Your change looks good (aside from the minor requested capitalization change) from a code perspective. I just need to run it through some tests to verify that there aren't any unexpected regressions that I'm missing from a cursory review.

You're quite welcome! And yes, please verify it further. I use your module in a script to generate a changelog and programmatically create a GitHub release with assets uploaded direct from the CI/CD machines. It's great! I definitely want it to keep working with PowerShell 7.4.

[andyleejordan]

Have you had a chance to test it more thoroughly yet? Thanks!

[andyleejordan]

Hey @HowardWolosky just following up on this as PowerShell 7.4 gets closer to GA (and will result in this module being quite broken without this change). 😄

[brogers5]

PowerShell 7.4 has since hit GA, and this issue is starting to impact module consumers like myself. Is there anything we can do to help move this PR forward?

[HowardWolosky]

@andyleejordan - Thanks so much for getting this change in. My apologies for not completing the testing/validation earlier before PS 7.4 got released. Merging this in now, and then will see if I can get a new module version published.

[andyleejordan]

Heck yeah, thanks @HowardWolosky!

[HowardWolosky]

This has been published to PowerShellGallery as part of 0.17.0: https://www.powershellgallery.com/packages/PowerShellForGitHub/0.17.0