Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tree alongside -a, --all displays wrong results #477

Closed
maxsatula opened this issue Jan 27, 2021 · 0 comments · Fixed by #485
Closed

--tree alongside -a, --all displays wrong results #477

maxsatula opened this issue Jan 27, 2021 · 0 comments · Fixed by #485
Labels
kind/bug Something isn't working

Comments

@maxsatula
Copy link

maxsatula commented Jan 27, 2021

  • os: Funtoo Linux
  • lsd --version: 0.19.0
  • echo $TERM: screen-256color
  • echo $LS_COLORS: rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=01;05;37;41:mi=01;05;37;41:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:.tar=01;31:.tgz=01;31:.arc=01;31:.arj=01;31:.taz=01;31:.lha=01;31:.lz4=01;31:.lzh=01;31:.lzma=01;31:.tlz=01;31:.txz=01;31:.tzo=01;31:.t7z=01;31:.zip=01;31:.z=01;31:.dz=01;31:.gz=01;31:.lrz=01;31:.lz=01;31:.lzo=01;31:.xz=01;31:.zst=01;31:.tzst=01;31:.bz2=01;31:.bz=01;31:.tbz=01;31:.tbz2=01;31:.tz=01;31:.deb=01;31:.rpm=01;31:.jar=01;31:.war=01;31:.ear=01;31:.sar=01;31:.rar=01;31:.alz=01;31:.ace=01;31:.zoo=01;31:.cpio=01;31:.7z=01;31:.rz=01;31:.cab=01;31:.wim=01;31:.swm=01;31:.dwm=01;31:.esd=01;31:.jpg=01;35:.jpeg=01;35:.mjpg=01;35:.mjpeg=01;35:.gif=01;35:.bmp=01;35:.pbm=01;35:.pgm=01;35:.ppm=01;35:.tga=01;35:.xbm=01;35:.xpm=01;35:.tif=01;35:.tiff=01;35:.png=01;35:.svg=01;35:.svgz=01;35:.mng=01;35:.pcx=01;35:.mov=01;35:.mpg=01;35:.mpeg=01;35:.m2v=01;35:.mkv=01;35:.webm=01;35:.ogm=01;35:.mp4=01;35:.m4v=01;35:.mp4v=01;35:.vob=01;35:.qt=01;35:.nuv=01;35:.wmv=01;35:.asf=01;35:.rm=01;35:.rmvb=01;35:.flc=01;35:.avi=01;35:.fli=01;35:.flv=01;35:.gl=01;35:.dl=01;35:.xcf=01;35:.xwd=01;35:.yuv=01;35:.cgm=01;35:.emf=01;35:.ogv=01;35:.ogx=01;35:.cfg=00;32:.conf=00;32:.diff=00;32:.doc=00;32:.ini=00;32:.log=00;32:.patch=00;32:.pdf=00;32:.ps=00;32:.tex=00;32:.txt=00;32:.aac=00;36:.au=00;36:.flac=00;36:.m4a=00;36:.mid=00;36:.midi=00;36:.mka=00;36:.mp3=00;36:.mpc=00;36:.ogg=00;36:.ra=00;36:.wav=00;36:.oga=00;36:.opus=00;36:.spx=00;36:.xspf=00;36:

Expected behavior

A directory is not supposed to display as its own child

Actual behavior

A directory itself and its parent are wrongly displayed as children of the directory when -a option is used with --tree.

Example, with and without -a option:

$ mkdir one two one/sub # create some directory structure as a test case
$ touch two/.hidden-file
$ lsd --tree -a  # a buggy output, see how three directories turned into a flood.
├──  .
├──  ./..
├──  one
│  ├──  one
│  ├──  ./one/..
│  └──  sub
│     ├──  sub
│     └──  ./one/sub/..
└──  two
   ├──  two
   ├──  ./two/..
   └──  .hidden-file

$ lsd --tree -A # the output above is expected to look closer to the following.
├──  one
│  └──  sub
└──  two
   └──  .hidden-file

I think it makes sense to list . and .. directories for the top level only (if it does at all), if -a is provided.

Thank you

@zwpaper zwpaper added the kind/bug Something isn't working label Jan 29, 2021
zwpaper added a commit to zwpaper/lsd that referenced this issue Feb 14, 2021
fix lsd-rs#477

Signed-off-by: zwPapEr <zw.paper@gmail.com>
zwpaper added a commit to zwpaper/lsd that referenced this issue Feb 14, 2021
fix lsd-rs#477

Signed-off-by: zwPapEr <zw.paper@gmail.com>
meain pushed a commit that referenced this issue Feb 15, 2021
fix #477

Signed-off-by: zwPapEr <zw.paper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants