Skip to content

incompatible api diff result when one of property in model becomes not required #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbxxxxx2a opened this issue Jun 22, 2023 · 2 comments
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification

Comments

@lbxxxxx2a
Copy link

lbxxxxx2a commented Jun 22, 2023

if in new api version some property is not required anymore, new api is recognized as not compatible

old api schema definition:

"SomeDto": {
        "required": [
          "prop1",
          "prop2",
          "prop3"
        ], ...

new api schema definition:

"SomeDto": {
        "required": [
          "prop1"
        ], ...
@typekpb
Copy link

typekpb commented Oct 30, 2023

same issue here

@joschi
Copy link
Contributor

joschi commented Dec 16, 2023

@lbxxxxx2a @typekpb Could you please provide a minimal set of OpenAPI specifications to demonstrate the issue?

@DrSatyr DrSatyr added bug and removed bug labels Jan 30, 2025
@DrSatyr DrSatyr added the Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification
Projects
None yet
Development

No branches or pull requests

4 participants