Add PR #1636

Author: johrstrom

apps/dashboard/app/models/batch_connect/app.rb

@@ -227,6 +227,17 @@ def submit_opts(session_context, fmt: nil, staged_root: nil)
       ctx_binding.local_variable_set(:staged_root, staged_root.to_s)
 
       hsh = hsh.deep_merge submit_config(binding: ctx_binding)
+
+    # let's write the file out if it's a submit.yml.erb that isn't valid yml
+    rescue Psych::SyntaxError => e
+      unless staged_root.nil?
+        yml = submit_file(root: root)
+        bad_content = render_erb_file(path: yml, contents: yml.read, binding: ctx_binding)
+        Pathname.new(staged_root).tap { |p| p.mkpath unless p.exist? }
+        File.open("#{staged_root}/submit.yml", 'w+') { |file| file.write(bad_content) }
+      end
+
+      raise e
     end
 
     # View used for session if it exists

apps/dashboard/test/fixtures/sys_with_interactive_apps/bc_paraview/submit.yml.erb

@@ -0,0 +1,4 @@
+---
+script:
+  native:
+  bad_yml_syntax

apps/dashboard/test/models/batch_connect/app_test.rb

@@ -239,4 +239,34 @@ def bad_clusters
       assert_equal opts[:script][:error_path], "#{dir}/error.log"
     end
   end
+
+  test "select widgets with no options values throws error" do
+    r = PathRouter.new("test/fixtures/sys_with_interactive_apps/broken_app")
+    app = BatchConnect::App.new(router: r)
+
+    Dir.mktmpdir do |dir|
+      exception = assert_raise StandardError do 
+        app.submit_opts(app.build_session_context, staged_root: dir)
+      end
+      assert_equal "The form.yml has missing options in the node_type form field.", exception.message
+    end
+  end
+
+  test "bad submit.yml.erb files write submit.yml" do
+    r = PathRouter.new("test/fixtures/sys_with_interactive_apps/bc_paraview")
+    app = BatchConnect::App.new(router: r)
+    expected_file = <<~HEREDOC
+      ---
+      script:
+        native:
+        bad_yml_syntax
+    HEREDOC
+
+    Dir.mktmpdir do |dir|
+      assert_raise Psych::SyntaxError do 
+        app.submit_opts(app.build_session_context, staged_root: dir)
+      end
+      assert_equal expected_file, File.read("#{dir}/submit.yml")
+    end
+  end
 end