Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftp location source does not return correct paths #1

Closed
Nimdraug opened this issue Apr 26, 2017 · 2 comments
Closed

ftp location source does not return correct paths #1

Nimdraug opened this issue Apr 26, 2017 · 2 comments
Assignees
Labels

Comments

@Nimdraug
Copy link
Owner

Nimdraug commented Apr 26, 2017

taters.locations.ftp( 'ftp://a.com/x/y' ).source() yields files with their dirname set to /x/y (as in /x/y/somefile.txt), which when passed to a local location will attempt to create that path, causing a permission error.

Additionally, local locs should not accept absolute paths in the first place, and always assume they are relative to the local loc's basepath. Fixing this would also resolve this issue.

@Nimdraug Nimdraug added the bug label Apr 26, 2017
@Nimdraug Nimdraug self-assigned this Apr 26, 2017
@Nimdraug
Copy link
Owner Author

taters.locations.ftp's source now behaves consistently, as does all the other of the locations.

local locs still accept files with absolute paths tho, which will need to be fixed in the future

@Nimdraug
Copy link
Owner Author

Locations accepting absolute files split into #2
Closing this as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant