-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyntaxWarnings Due to Invalid Escape Sequences in DropTags.py #12
Comments
…p-tags fix: invalid escape sequences in DropTags module (#12)
I think this change removed support for regex matching, as you are now calling You should add "The application continues to support using regular expressions to match tags" to your expected behavior list, as not removing the feature you are fixing is important. |
@maedtb Thanks for catching that. We should probably think about adding unit tests specifically to verify that regex-based matching continues to work as intended and doesn’t regress in future changes. Regarding the remark about the expected behavior list - I appreciate the feedback, but let’s keep the discussion focused on solving the issue rather than adding unnecessary puns. please review if it works as intended with this pr #19 |
When running OneTrainer, several SyntaxWarnings are raised because of invalid escape sequences in the
DropTags.py
module. These warnings indicate that certain escape sequences (e.g.,\{
,\)
, and\(
) are not properly formatted in Python string literals. This may lead to unintended behavior in regex processing.Steps to Reproduce:
Start OneTrainer
Observe the following warnings in the console output:
Expected Behavior:
Environment:
The text was updated successfully, but these errors were encountered: