fix(android): tabs inside modal throw error on close #8879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should wait to see if #8793 fixes it (or breaks this PR) |
NathanWalker
force-pushed
the
master
branch
from
d4ced42 to
53488b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When closing a modal with back button (or tapping outside), things that depend on Fragments (like Tabs) will throw an error because the fragment was already disposed.
What is the new behavior?
Unloaded is called first, giving a chance for the components to clean up before modal close.
Might be worth it to wait for e2e testing to work again before merge.
Fixes NativeScript/nativescript-angular#2259.