✨ Feature(tcyun): add slim section #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molunerfinn
reviewed
Aug 22, 2023
| @@ -61,6 +61,23 @@ | |||
| :value="choice.value || choice" | |||
| /> | |||
| </el-select> | |||
| <div v-else-if="item.type === 'switch'"> | |||
There was a problem hiding this comment.
这里不要直接用 type === 'switch'，因为 inquirer 没有 type === switch 这种类型
参考 picgo-core 的评论，可以换成 guiType PicGo/PicGo-Core#156
Molunerfinn
reviewed
Aug 22, 2023
| active-text="开启" | ||
| inactive-text="关闭" | ||
| /> | ||
| <div class="tcyun-tips"> |
There was a problem hiding this comment.
这里不能这么写，这样写一旦有别的图床插件用了这种类型，难道都展示腾讯云的tips么
Molunerfinn
reviewed
Aug 23, 2023
| /> | ||
| <div v-if="item.tips" class="tcyun-tips" @mouseenter="() => isHoverTips = true" @mouseleave="() => isHoverTips = false"> |
There was a problem hiding this comment.
这个 class 类名就不要用 tcyun-tips 了。 PicGo 已经接入 tailwind ，可以用 tailwind 写 css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(slim): add slim section