Skip to content

Commit 811b516

Browse files
committed
Adding parenthesis around 'bitvalue' allowing correct macro expansion
when using with ternary operator such as bitWrite(value, bit, some_computed_value == 5 ? 1: 0);
1 parent e16f14c commit 811b516

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Arduino.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ void yield(void);
153153
#define bitSet(value, bit) ((value) |= (1UL << (bit)))
154154
#define bitClear(value, bit) ((value) &= ~(1UL << (bit)))
155155
#define bitToggle(value, bit) ((value) ^= (1UL << (bit)))
156-
#define bitWrite(value, bit, bitvalue) (bitvalue ? bitSet(value, bit) : bitClear(value, bit))
156+
#define bitWrite(value, bit, bitvalue) ((bitvalue) ? bitSet(value, bit) : bitClear(value, bit))
157157

158158
// avr-libc defines _NOP() since 1.6.2
159159
#ifndef _NOP

0 commit comments

Comments
 (0)