Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

added formula for ponyc compiler #39192

Closed
wants to merge 14 commits into from
Closed

added formula for ponyc compiler #39192

wants to merge 14 commits into from

Conversation

sblessing
Copy link

No description provided.

MikeMcQuaid
MikeMcQuaid reviewed Apr 29, 2015
View reviewed changes
Library/Formula/ponyc.rb
version "0.1.1"
sha256 "8ed8e5139635cf7f60cf87d51fd36210ab11a8a7fcefbdfa9b5c25a2666bee1e"

depends_on "homebrew/versions/llvm36"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't depend on taps in core formulae, I'm afraid. This will need to be vendored.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we would need to provide a seperate tap for ponyc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can't vendor it: yeh.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 0536279, I have updated the llvm formula to the latest official release, as it was outdated. With this, the ponyc formula does not depend on any non-core formulas.

Submitting a new pull request!

@MikeMcQuaid
Copy link
Member

Let's wait for it to land in #37260.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Apr 30, 2015
Closed
@sblessing
Copy link
Author

Ok. Thanks for your support.

@sblessing sblessing mentioned this pull request May 4, 2015
Closed
@tdsmith tdsmith mentioned this pull request May 4, 2015
Closed
@sblessing
Copy link
Author

#37260 is now closed. I have made sure that this pull request can be auto-merged into master. Would be cool if finally ponyc.rb can be merged into homebrew-core!

Thanks,
Sebastian

@sblessing
Copy link
Author

Actually, there appears to be some linker issues. Please do not merge this pull request right now.

Sorry for the inconvenience.

@sblessing
Copy link
Author

The problem is that new llvm 3.6.0 formula recently merged is ignoring the option --with-rtti, consequently causing link-errors for ponyc 0.1.3

$ brew install -v llvm --with-rtti
[...]
Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTOCodeGenerator.cpp.o
cd /tmp/llvm20150511-23271-jeimnn/lib/LTO && /usr/local/Library/ENV/4.3/clang++   [...] *-fno-rtti* -o CMakeFiles/LLVMLTO.dir/LTOCodeGenerator.cpp.o -c /tmp/llvm20150511-23271-1tzi010/llvm-3.6.0.src/lib/LTO/LTOCodeGenerator.cpp

I have opened an issue for this, #39609.

@sblessing sblessing mentioned this pull request May 10, 2015
Closed
jacknagel
jacknagel reviewed May 10, 2015
View reviewed changes
Library/Formula/llvm.rb
args = %w[
-DLLVM_OPTIMIZED_TABLEGEN=On
]

args << "-DLLVM_ENABLE_RTTI=True" if build.with? "rtti" || build.with? "clang"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the parentheses in this conditional (it's invalid syntax otherwise)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

brew audit --strict llvm
==> brew style llvm

1 file inspected, no offenses detected

@jacknagel
Copy link
Contributor

This needs to be rebased down to one commit fixing the llvm issue, and another adding the new formula (preferrably in separate pull requests as well).

tamird
tamird reviewed May 11, 2015
View reviewed changes
Library/Formula/llvm.rb
args = %w[
-DLLVM_OPTIMIZED_TABLEGEN=On
]

args << "-DLLVM_ENABLE_RTTI=True" if build.with?("rtti") || build.with?("clang")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to be "On", not "True"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are right, although the llvm cmake docu with LLVM_ENABLE_RTTI:BOOL is inaccurate. It doesn't make a difference for making it work btw.

@sblessing
Copy link
Author

I will close this pull request and make the necessary changes. I'll submit two new ones.

@sblessing sblessing closed this May 11, 2015
@sblessing
Copy link
Author

Ok. I have split ponyc and the lllvm fix.

#39629
#39630

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sblessing @MikeMcQuaid @jacknagel @tamird