Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on previewing some files #485

Closed
Canop opened this issue Jan 21, 2022 · 3 comments
Closed

Crash on previewing some files #485

Canop opened this issue Jan 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Canop
Copy link
Owner

Canop commented Jan 21, 2022

I've an example of a svelte file: See trishume/syntect#421

The bug is in the syntect library that I use for syntax highlighting.

This library unfortunately contains some panic and crashes instead of returning an error.

The options here seem to be

  1. find another crate for syntax highlighting: I know none (I'll only consider pure Rust ones)
  2. wait for syntect 5 to be available, assuming this bug would be fixed (if it isn't, it would be at least easier to contribute)
  3. fork syntect and remove the encountered cases of panic (then wait for syntect 5, I won't try to maintain a dedicated fork longer than strictly necessary)
  4. try to unwind the panic...

If you encountered the crash when previewing a file, please tell me.

@Canop Canop added the bug Something isn't working label Jan 21, 2022
@Canop
Copy link
Owner Author

Canop commented Jan 21, 2022

I went for the temporary fork road to ensure I have a version of broot not crashing when previewing files.

@Canop
Copy link
Owner Author

Canop commented Jan 21, 2022

Fixed by commit d75f758

@Canop Canop closed this as completed Jan 21, 2022
@Canop
Copy link
Owner Author

Canop commented Mar 18, 2023

Syntect 5.0 panics too, in a different way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant