Merge pull request #128 from thegeorgeous/124-fix-instanceof

CacheControl · web-flow · commit 5a2723f48707 · 2019-04-26T11:57:47.000-06:00
Use Array.isArray instead of instanceof
diff --git a/src/condition.js b/src/condition.js
@@ -10,7 +10,7 @@ export default class Condition {
     Object.assign(this, properties)
     if (booleanOperator) {
       let subConditions = properties[booleanOperator]
-      if (!(subConditions instanceof Array)) {
+      if (!(Array.isArray(subConditions))) {
         throw new Error(`"${booleanOperator}" must be an array`)
       }
       this.operator = booleanOperator

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ export default class Condition {`
`10`	`10`	`Object.assign(this, properties)`
`11`	`11`	`if (booleanOperator) {`
`12`	`12`	`let subConditions = properties[booleanOperator]`
`13`		`- if (!(subConditions instanceof Array)) {`
	`13`	`+ if (!(Array.isArray(subConditions))) {`
`14`	`14`	throw new Error(`"${booleanOperator}" must be an array`)
`15`	`15`	`}`
`16`	`16`	`this.operator = booleanOperator`