Skip to content

feat(core): Add an assert_any_suggestion_result test function #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hippietrail opened this issue Mar 21, 2025 · 0 comments · May be fixed by #1033
Open

feat(core): Add an assert_any_suggestion_result test function #950

hippietrail opened this issue Mar 21, 2025 · 0 comments · May be fixed by #1033
Assignees
@hippietrail
Labels
enhancement New feature or request harper-core

Comments

@hippietrail
Copy link
Collaborator

It would be nice to have a testing assertion along with assert_suggestion_result() and assert_nth_suggestion_result() that passes of the test no matter which suggestion appears in the result.

I looked at implementing this briefly a week or two ago and decided I didn't know enough about the architecture to do it efficiently.
hippietrail added a commit to hippietrail/harper that referenced this issue Apr 5, 2025
@hippietrail
feat: implement assert_any_suggestion_result as in Automattic#950
ad8b8c3
@hippietrail hippietrail linked a pull request Apr 5, 2025 that will close this issue
Draft
2 tasks
@hippietrail hippietrail self-assigned this Apr 7, 2025
@hippietrail hippietrail added enhancement New feature or request harper-core labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hippietrail hippietrail

Labels
enhancement New feature or request harper-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement assert_any_suggestion_result as in #950 hippietrail/harper
1 participant
@hippietrail