feat: sequence support BatchMsg
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffeastrom
force-pushed
the
feat/sequence-support-batch
branch
2 times, most recently
from
3f6b84b to
75f21a9
Compare
stoffeastrom
force-pushed
the
feat/sequence-support-batch
branch
from
75f21a9 to
5f6e8fc
Compare
|
This makes a ton of sense to me; thank you for the PR. We just merged another PR that touches this portion this code and is now causing a conflict. Do you mind updating your PR accordingly? |
stoffeastrom
force-pushed
the
feat/sequence-support-batch
branch
from
5f6e8fc to
2e4e547
Compare
|
@meowgorithm Rebased. Let me know if anything else is needed! |
stoffeastrom
force-pushed
the
feat/sequence-support-batch
branch
2 times, most recently
from
8271571 to
adca91e
Compare
|
@meowgorithm saw there was some mismatch in |
Thank you! |
muesli
reviewed
Feb 6, 2023
stoffeastrom
force-pushed
the
feat/sequence-support-batch
branch
from
adca91e to
4ce44c6
Compare
|
Apparently I missed updating |
|
Alright, this looks good! Thanks for all your help with this, @stoffeastrom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#415 added support for
tea.Sequence. This adds support fortea.Batchcmd in thetea.Sequencecmd.Fixes #582