Use different socket for Win32 test #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Xianming Zhong <chinesedfan@qq.com>
…3030/axios into cleanup/remove-test-skipping
|
Not sure how this would specifically resolve the error in #3364 and I do not have a sauce key. I tried testing Chrome 86, Win7, Node.js 10.0.0 multiple time with no error. Will try the Win10 failures when my VM finishes (tomorrow). |
timemachine3030
changed the title
|
Now the CI works well. If it is stable enough, we can ignore. |
|
This is still worth merging. Any developer on Windows, running the tests, will get an error. |
|
I think this is a good idea to have it merged, there is a large user base on Windows and this could potentially keep people from contributing in the future and we don't want that. |
This was referenced Jan 5, 2021
This was referenced Mar 5, 2021
This was referenced Mar 18, 2021
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* Remove the skipping of the `socket` http test * Use different socket path for Win32 - See: https://github.com/nodejs/node-v0.x-archive/blob/master/test/simple/test-pipe-stream.js#L73 - Also: https://github.com/nodejs/node-v0.x-archive/blob/master/test/common.js#L39 * Updating axios in types to be lower case (axios#2797) Co-authored-by: Xianming Zhong <chinesedfan@qq.com> Co-authored-by: Pilot <timemachine@ctrl-c.club> Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Co-authored-by: Xianming Zhong <chinesedfan@qq.com> Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different socket path for Win32