Skip to content

Not able to add IAM role #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VikasMGowda05 opened this issue Dec 9, 2024 · 6 comments
Open

Not able to add IAM role #6086

VikasMGowda05 opened this issue Dec 9, 2024 · 6 comments
Assignees
Labels
status/need-feedback Calling participant to provide feedback

Comments

@VikasMGowda05
Copy link

VikasMGowda05 commented Dec 9, 2024

Description:
How can we add the pod annotaions, I need to add the IAM roles for all pods which gets launched by SCDF.

Release versions:

we are using "bitnami/spring-cloud-dataflow:2.11.5-debian-12-r2"

Screenshots:
Sample screen shot is below
@@
Screenshot 2024-12-09 at 1 18 15 PM

Additional context

Below is our values.yaml file

server:
image:
registry: docker.io
repository: bitnami/spring-cloud-dataflow
tag: 2.11.5-debian-12-r2
digest: ""
pullPolicy: IfNotPresent
pullSecrets: []
debug: false
composedTaskRunner:
image:
registry: docker.io
repository: bitnami/spring-cloud-dataflow-composed-task-runner
tag: 2.11.5-debian-12-r2
digest: ""
configuration:
streamingEnabled: false
batchEnabled: true
accountName: default
trustK8sCerts: false
containerPorts:
http: 8080
jdwp: 5005
replicaCount: 1
updateStrategy:
type: RollingUpdate
startupProbe:
enabled: false
initialDelaySeconds: 120
timeoutSeconds: 1
periodSeconds: 20
failureThreshold: 6
successThreshold: 1
livenessProbe:
enabled: true
initialDelaySeconds: 120
timeoutSeconds: 1
periodSeconds: 20
failureThreshold: 6
successThreshold: 1
readinessProbe:
enabled: true
initialDelaySeconds: 120
timeoutSeconds: 1
periodSeconds: 20
failureThreshold: 6
successThreshold: 1
networkPolicy:
enabled: false
allowExternal: false
allowExternalEgress: false
service:
type: ClusterIP
ports:
http: 8080
ingress:
enabled: true
path: /
pathType: ImplementationSpecific
hostname: "xyz.com"
pdb:
create: false
minAvailable: ""
maxUnavailable: ""
pdb:
create: false
skipper:
enabled: false
rabbitmq:
enabled: false
mariadb:
enabled: false
metrics:
enabled: false
pdb:
create: false
externalDatabase:
host: "{{RDS-endpoint}}.rds.amazonaws.com
driver: com.mysql.cj.jdbc.Driver
dataflow:
url: "{Database url}"
username:
password:

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Dec 9, 2024
@corneil
Copy link
Contributor

corneil commented Dec 9, 2024

I believe there are podAnnotations in the Bitnami Helm values schema.
You can set different for skipper stream deployments and dataflow task launches.

@corneil corneil added status/need-feedback Calling participant to provide feedback and removed status/need-triage Team needs to triage and take a first look labels Dec 9, 2024
@VikasMGowda05
Copy link
Author

We are using this as below as we didn't find the dataflow task launches and it is not working, could you please suggest here

server:
podAnnotations:
iam.amazonaws.com/role: ' '
service:
annotations:
iam.amazonaws.com/role: ' '

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels Dec 9, 2024
@VikasMGowda05
Copy link
Author

@corneil , will you please help here

@cppwfs
Copy link
Contributor

cppwfs commented Dec 9, 2024

If you are trying to add pod annotations to your application you can add them using the following instructions:https://docs.spring.io/spring-cloud-dataflow/docs/current/reference/htmlsingle/#_annotations

@cppwfs cppwfs added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Dec 9, 2024
@VikasMGowda05
Copy link
Author

Hi @cppwfs , we have tried that , its not working. Please check the below configuration for reference and Thanks in advance.

deployer:
dsp:
kubernetes:
podAnnotations: iam.amazonaws.com/role:''
serviceAnnotations: iam.amazonaws.com/role:''
jobAnnotations: iam.amazonaws.com/role:''

deployer:
default:
kubernetes:
podAnnotations: iam.amazonaws.com/role:''
serviceAnnotations: iam.amazonaws.com/role:''
jobAnnotations: iam.amazonaws.com/role:''

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels Dec 9, 2024
@corneil
Copy link
Contributor

corneil commented Dec 9, 2024

It seems like the Bitnami Helm chart doesn't provide for adding a generic block of configuration for dataflow or skipper like we do in our Carvel deployment. The plain kubernetes deployment also provides for extending the spring.cloud.dataflow or spring.cloud.skipper configuration with YAML or environment variables. https://docs.spring.io/spring-cloud-dataflow/docs/current/reference/htmlsingle/#configuration-kubernetes
It seems like you will have to use extraEnvVarsCM or extraEnvVars to provide the full properties like

server:
  extraEnvVars:
    - name: SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEFAULT_PODANNOTATIONS
      value: "iam.amazonaws.com/role: ''"
    - name: SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEFAULT_JOBANNOTATIONS
      value: "iam.amazonaws.com/role: ''""

@github-actions github-actions bot added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-feedback Calling participant to provide feedback
Projects
None yet
Development

No branches or pull requests

3 participants