Skip to content

Updating support for Array API to v2024.12 #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Updating support for Array API to v2024.12 #863

wants to merge 7 commits into from
+107 −11

Conversation

prady0t
Copy link
Contributor

@prady0t prady0t commented Apr 10, 2025

Fixes #858

@prady0t
Updating support for Array API to v2024.12
156435e 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t prady0t marked this pull request as draft April 10, 2025 20:14
@prady0t
Copy link
Contributor Author

prady0t commented Apr 10, 2025

There are a total of 96 new failures. I'll keep trying to fix the easy ones in the following commits.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #863 will degrade performances by 98.68%

Comparing prady0t:array-api-version-2024.12 (22f810d) with main (afb5212)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_index_slice[side=100-rank=2-format='gcxs'] 2.6 ms 2.3 ms +13.08%
❌ test_elemwise[f=<built-in function gt>-backend='Finch'-side=500] 859.6 µs 65,315.3 µs -98.68%

hameerabbasi
hameerabbasi requested changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small edit.

prady0t and others added 4 commits April 12, 2025 02:20
@prady0t
Adding list of failing tests to xfails
fd132d3 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Adding 2023.12 to list of supported versions
3324165 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Adding failed clip test
f5eb428 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d6bac93 
for more information, see https://pre-commit.ci
@prady0t
Copy link
Contributor Author

prady0t commented Apr 12, 2025

@hameerabbasi Could you trigger the CI run?

@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Apr 14, 2025 •
edited
Loading

I'd suggest pushing an empty commit -- seems like the CI checks failed to start for some other reason. We only restrict them for someone making their first PR.

@hameerabbasi
Copy link
Collaborator

We also need to bump the commit hash of array-api-tests in ci/array-api-tests-rev.txt.

@prady0t
Commit hash for 2024.12
22f810d 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Copy link
Contributor Author

prady0t commented Apr 15, 2025

How to get the commit hash?

@hameerabbasi
Copy link
Collaborator

Look at the current hash at the default branch of the array api tests repo.

And then adjust the list of failures accordingly; it'll change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enh: Update support for Array API to v2024.
2 participants
@prady0t @hameerabbasi