Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for missing kinds and suggestions for existing kinds #12

Open
astier opened this issue Jun 4, 2021 · 2 comments
Open

Icons for missing kinds and suggestions for existing kinds #12

astier opened this issue Jun 4, 2021 · 2 comments

Comments

@astier
Copy link

astier commented Jun 4, 2021

Problem

The following kinds are not defined:

  • Field
  • Reference
  • Event
  • Operator
  • TypeParameter

The following kinds are defined but could have better icons:

  • Method ƒ
  • Class

Solutions

I tried to find icons similar to the icons which are used by vscode. As a reference I used the official vscode-icon-reference. Search for symbol-class to find the icon for a class.

  • Field: Completely forgot to search for this one but since it is basically a variable I personally would use the same icon as the Variable-kind. I will leave it to somebody else to search for a better icon.
  • Reference: ⇲                  淚 漏 社 I think is nice and looks similar to vscode.
  • Event:       勞 異 𥉉 ﯓ ﯧ ﯦ ﱥ ﴞ  vscode has
  • Operator:  樂 洛 烈 ﲂ I hopped to find some kind of calculator icon like the vscode symbol where the four operations +-%= are shown but I couldn't find one. I picked for myself.
  • TypeParameter: T    﫳 My favorite is because generic types are usually put in such brackets.
  • Method
  • Class

I have no issues with the Keyword- and Text-kind but here are some alternatives:

  • Keyword:  
  • Text: this looks like the official vscode icon for text but is very small on my computer.

Related

#1
#5
#11

@stellarhoof
Copy link
Contributor

Here's my configuration with a nerd font

require "vim.lsp.protocol".CompletionItemKind = {
  "  (text)",
  "  (method)",
  "  (fun)",
  "  (constructor)",
  "ﰠ  (field)",
  " (var)",
  "ﴯ  (class)",
  "  (interface)",
  "  (module)",
  "ﰠ  (property)",
  "塞 (unit)",
  "  (value)",
  "  (enum)",
  "  (keyword)",
  "  (snippet)",
  "  (color)",
  "  (file)",
  "  (reference)",
  "  (folder)",
  "  (enum-member)",
  "  (constant)",
  "פּ  (struct)",
  "  (event)",
  "  (operator)",
  "   (type-param)"
}

Screen Shot 2021-07-25 at 1 48 43 PM

@onsails
Copy link
Owner

onsails commented Jul 26, 2021

Here's my configuration with a nerd font

require "vim.lsp.protocol".CompletionItemKind = {
  "  (text)",
  "  (method)",
  "  (fun)",
  "  (constructor)",
  "ﰠ  (field)",
  " (var)",
  "ﴯ  (class)",
  "  (interface)",
  "  (module)",
  "ﰠ  (property)",
  "塞 (unit)",
  "  (value)",
  "  (enum)",
  "  (keyword)",
  "  (snippet)",
  "  (color)",
  "  (file)",
  "  (reference)",
  "  (folder)",
  "  (enum-member)",
  "  (constant)",
  "פּ  (struct)",
  "  (event)",
  "  (operator)",
  "   (type-param)"
}
Screen Shot 2021-07-25 at 1 48 43 PM

@stellarhoof thank you! would you mind adding it as a preset here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants