You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation should not rely on internal members. The goal is to expose minimal required to make it possible to implement new extendable by the third-partied modules.
Usage example
varbidi=awaitdriver.AsBiDiAsync();// selenium responsibility// straightforward API (not yet approved)varpermissionsModule=newPermissionsModule(bidi);// or as extension to emphasize this is extensionvarpermissionsModule=bidi.AsPermissions();awaitpermissionsModule.QueryAsync();
The text was updated successfully, but these errors were encountered:
@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.
Info for maintainers
Triage this issue by using labels.
If information is missing, add a helpful comment and then I-issue-template label.
If the issue is a question, add the I-question label.
If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable G-* label, and it will provide the correct link and auto-close the
issue.
After troubleshooting the issue, please add the R-awaiting answer label.
I am thinking more about it and coming to a conclusion that "reusing" existing BiDi connection is "not possible". JsonSerializerContext is immutable, reading it as third-party module should initialize his own connection (Broker) providing described json context.
So, I think the following will be more appreciated:
varbidi=awaitdriver.AsBiDiAsync();// W3C WebDriver implementationvarpermissions=awaitdriver.AsBiDiPermissionsAsync();// It initializes new Broker/WebSocketConnection/JsonContext
Then each bidi and permissions are isolated, and both have own "context" including everything needed to deal with remote end (still immutable). The trick is that remote end send data (responses/events) per WebSocketConnection.
I think this is a good solution. But semantic of this solution is not related to extensibility.
Feature and motivation
https://www.w3.org/TR/permissions/
The implementation should not rely on
internal
members. The goal is to expose minimal required to make it possible to implement new extendable by the third-partied modules.Usage example
The text was updated successfully, but these errors were encountered: