Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you could add few type hints to the code files so that it would be easy to interpret the code in a much easier way. #3

Open
vignesh1507 opened this issue Oct 4, 2024 · 1 comment

Comments

@vignesh1507
Copy link

This can be taken as a suggestion and not as a serious issue, if needed any help with the type hints part then i can help you with that part.

@Querela
Copy link
Owner

Querela commented Oct 8, 2024

As far as I'm concerned, this library has type hints. But everything can be improved, so if you have good suggestions, I can review them ...

Please also check your changes with mypy. In the setup.cfg all the dev tools are defined for typing, styling/formatting, building etc.
You will also notice that I'm intentionally excluding the vendor library ply since it's just a copy and future updates will simply replace the source files. So, any type hinting there is a bit wasted should better be contributed to the project itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants