-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ordered_imports
should not take the braces part in grouped imports into account
#5347
Comments
This comment was marked as outdated.
This comment was marked as outdated.
ordered_imports
should not take the braces part in grouped imports into account
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
In addition, PhpStorm uses this variation of alpha sorting. And now we have a discrepancy between phpstorm sorting and php-cs-fixer sorting. And there is no way to configure them to work the same way. |
Since this issue has not had any activity within the last 90 days, I have marked it as stale. The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way. You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point. I will close it if no further activity occurs within the next 30 days. |
The fact this was automatically closed doesn't mean that the idea got rejected - it simply didn't get any priority for way too long to keep it open. If you are interested in implementing this yourself, please share the implementation draft to align on the approach, before you prepare the full implementation. |
Bug report
ordered_imports
rule should not take the braces part in grouped imports into account.Code snippet that reproduces the problem
This will be fixed to
while it should not be changed because
Foo\
comes beforeFoo\NotBarNorBar\DeeperClass
.Maybe this can be considered an improvement rather than a bug though.
The text was updated successfully, but these errors were encountered: