You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By default, fixLoc returns place names without particles such as "de", "of", etc.
The data in replaceNames has this baked into it for some names, eg "rj" is turned into "rio janeiro". However, "rio de janeiro" isn't transformed, generating an inconsistency.
I think these functions should be able to return proper place names, eg "Rio de Janeiro", and the removal of particles should be optional. This would mean replaceNames would have to slightly modified, and a couple of lines of code added to remove the particles afterwards, optionally. This would also fix the inconsistency I mentioned above.
Also I would like to reorganize the code in fixLoc into separate subfunctions for each admin level, when possible, ie, fixCountry, fixState, fixMunicipality, or something similar. prepCountry already does most of the work in fixing the country data, and there's no clear reason why it doesn't do the rest. It would also have to be editted to allow returning full place names without removal of particles.
The text was updated successfully, but these errors were encountered:
By default, fixLoc returns place names without particles such as "de", "of", etc.
The data in replaceNames has this baked into it for some names, eg "rj" is turned into "rio janeiro". However, "rio de janeiro" isn't transformed, generating an inconsistency.
I think these functions should be able to return proper place names, eg "Rio de Janeiro", and the removal of particles should be optional. This would mean replaceNames would have to slightly modified, and a couple of lines of code added to remove the particles afterwards, optionally. This would also fix the inconsistency I mentioned above.
Also I would like to reorganize the code in fixLoc into separate subfunctions for each admin level, when possible, ie, fixCountry, fixState, fixMunicipality, or something similar. prepCountry already does most of the work in fixing the country data, and there's no clear reason why it doesn't do the rest. It would also have to be editted to allow returning full place names without removal of particles.
The text was updated successfully, but these errors were encountered: