WebSocket Root Name

[CICADA-dev64bit]

Hey @Kaliumhexacyanoferrat. thanks for the quick mTLS support on the previous version of Genhtttp. kudos for that!
Right now im facing one more issue

var api = Layout.Create()   
     .Add("route1", socketController.create())
.AddService<ControllerOne>("route1");
 
var layout = Layout.Create()
         .Add(api)
         .Add(CorsPolicy.Permissive());
 
var server = Host.Create()
     .Handler(layout)
     .Development()
     .Console()
     .Port(port);
server.StartAsync();

We are creating server which should support both websocket and Rest API. And both needs to share same route name like example
http://localhost:8080/route1/ and ws://localhost:8080/route1/. But we are facing error while server starting itself. Our question is how to handle both websocket connection and Rest API connection with same route name, is that possible?

thanks in advance

[Kaliumhexacyanoferrat]

You can add a layout with two fallback handlers:

var route1 = Layout.Create()
                   .Add(ServiceResource.From<...>())
                   .Add(socketController.create());

var layout = Layout.Create()
                   .Add("route1", route1);

This way first the service, then the socket will try to handle the incoming request. In general, I would advice against such a setup as it is quite obscure what will happen for different requests.

[CICADA-dev64bit]

We have tried this way and this works fine for ws but http and https is not working, its throwing the below error

{
    "status": 400,
    "message": "Websocket upgrade request expected",
    "stackTrace": "   at GenHTTP.Modules.Websockets.Handler.WebsocketHandler.HandleAsync(IRequest request)\r\n   at GenHTTP.Modules.Layouting.Provider.LayoutRouter.HandleAsync(IRequest request)\r\n   at GenHTTP.Modules.Layouting.Provider.LayoutRouter.HandleAsync(IRequest request)\r\n   at GenHTTP.Modules.ErrorHandling.Provider.ErrorSentry`1.HandleAsync(IRequest request)"
}

[Kaliumhexacyanoferrat]

Considering the following minimal example:

var route1 = Layout.Create()
                   .Add(ServiceResource.From<MyService>())
                   .Add(Websocket.Create()); // or .Index() if you want the socket only to respond to /route1/

var app = Layout.Create()
                .Add("route1", route1);

await Host.Create()
          .Handler(app)
          .RunAsync();

public class MyService
{

    [ResourceMethod("/some")]
    public string GetSome() => "some";

}

I can call both http://localhost/route1/some which returns some and http://localhost/route1/ which acts as a Websocket endpoint. Not entirely sure about your motivation in the first place - what HTTP requests would you like to execute against your app?

[Kaliumhexacyanoferrat]

I guess your issue is that when the root (/route1/) gets called via GET, you want it to behave either as a websocket or a REST API call. While I strongly advise against such an app URL design, you can implement a switch in your service:

var app = Layout.Create()
                .AddService<MyService>("route1");

await Host.Create()
          .Handler(app)
          .RunAsync();

public class MyService
{
    private static IHandler _websocket = Websocket.Create().Build();

    [ResourceMethod]
    public async Task<IResponse?> Index(IRequest request)
    {
        // detect websocket connection in HTTP GET request
        if (request.Headers.TryGetValue("Upgrade", out var upgrade) && upgrade == "websocket")
        {
            return await _websocket.HandleAsync(request);
        }

        // build your regular response here
        return request.Respond()
                      .Content(new StringContent("Hello World")) // or JsonContent
                      .Build();
    }

}

[Kaliumhexacyanoferrat]

As this has been stale for some time I will close the discussion - feel free to re-open it if there is still something to clarify.